Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Add .sdkmanrc for Java #4888

Merged
merged 3 commits into from Feb 11, 2023
Merged

feat(java): Add .sdkmanrc for Java #4888

merged 3 commits into from Feb 11, 2023

Conversation

iuhoay
Copy link
Contributor

@iuhoay iuhoay commented Feb 7, 2023

Description

Add https://sdkman.io/ for Java. If a .sdkmanrc file is present, show the Java version.

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

davidkna

This comment was marked as outdated.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the table in the English java module docs.

@iuhoay
Copy link
Contributor Author

iuhoay commented Feb 8, 2023

@davidkna Doc is updated.

@davidkna davidkna merged commit 07c2298 into starship:master Feb 11, 2023
@davidkna
Copy link
Member

Thanks for the contribution @iuhoay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants