Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git_status): Avoid printing error on missing stash ref #5434

Merged
merged 2 commits into from Dec 16, 2023
Merged

fix(git_status): Avoid printing error on missing stash ref #5434

merged 2 commits into from Dec 16, 2023

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Sep 11, 2023 •
edited

Description

Decrease the default log level to avoid printing warnings too eagerly.

Motivation and Context

Closes #5432

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna merged commit 00d3dc8 into starship:master Dec 16, 2023
16 of 17 checks passed
@davidkna davidkna deleted the fix-stash branch December 16, 2023 15:58
@davidkna
Copy link
Member Author

Thanks for reviewing @andytom.

@github-actions github-actions bot mentioned this pull request Dec 16, 2023
Merged
@chiefmikey chiefmikey mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytom andytom andytom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git_status module prints "Error finding stash reference" if there are no stashed changes
2 participants
@davidkna @andytom