fix(bash): unbound variable error with STARSHIP_PREEXEC_READY #5438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am installing starship on a Docker container, and every now and then I see the following:
/dev/fd/63: line 24: STARSHIP_PREEXEC_READY: unbound variable
On this particular use case I installed https://github.com/junegunn/fzf on the container and then running:
/opt/fzf/install --help
just gives the above error. Not sure why it. doesn't happen to every command.I figured this is because STARSHIP_PREEXEC_READY can be non existent at some point. Exporting STARSHIP_PREEXEC_READY=true in the terminal fixes it.
I propose to account for this scenario in the bash-init script.
EDIT: I made a script to easily reproduce this:
Obviously is the
set -u
that triggers it