feat: Adding the AWS SSO CLI env variable to profile list #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02strich
force-pushed
the
add-aws-sso-cli
branch
from
70ad632
to
196b746
Compare
Adding support for the profile env variable used by https://github.com/synfinatic/aws-sso-cli
02strich
force-pushed
the
add-aws-sso-cli
branch
from
196b746
to
857ec16
Compare
davidkna
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for the profile env variable used by https://github.com/synfinatic/aws-sso-cli
Motivation and Context
I am using https://github.com/synfinatic/aws-sso-cli as CLI for AWS SSO, which uses a different env variable name than the tools already supported. So I added the additional variable name to the existing list.
How Has This Been Tested?
I have tested this on MacOS with a local build of starship, together with the most recent version of aws-sso-cli. Tests included correct rendering with sso context as well as with context.
Checklist: