Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v1.17.0 post-release fix-ups #5660

Merged
merged 4 commits into from Dec 30, 2023
Merged

Conversation

davidkna
Copy link
Member

Description

  • cargo update to fix NetBSD builds (v1.17.0 fails to build on NetBSD #5659)
  • dprint: ignore bn-BD alongside the other translated docs.
  • Downgrade node to v16 in notarize_and_pkgbuild to match publish_docs

Motivation and Context

May close #5659

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna changed the title fix: v1.17 post-release fix-ups fix: v1.17.0 post-release fix-ups Dec 29, 2023
@davidkna davidkna merged commit 89dc192 into starship:master Dec 30, 2023
22 checks passed
@davidkna davidkna deleted the v1.17-fixups branch December 30, 2023 16:28
@davidkna
Copy link
Member Author

Thanks for the reviews @andytom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.17.0 fails to build on NetBSD
2 participants