Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(direnv): use JSON status with direnv >= 2.33.0 #5692

Merged
merged 1 commit into from Jan 21, 2024

Conversation

Ajpantuso
Copy link
Contributor

Description

Starting with version 2.33.0 direnv produces machine parsable status output in the form of JSON. These changes update the direnv module to utilize the JSON output when possible to avoid parsing unstructured output.

Motivation and Context

Improves maintainability of the direnv module

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkna davidkna changed the title feat(direnv): add support for JSON status with direnv >= 2.33.0 feat(direnv): use JSON status with direnv >= 2.33.0 Jan 21, 2024
@davidkna davidkna merged commit 482c7b7 into starship:master Jan 21, 2024
17 checks passed
@davidkna
Copy link
Member

Thanks for the contribution @Ajpantuso!

@Ajpantuso Ajpantuso deleted the apantuso/direnv_json_support branch January 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants