feat(quarto): Add Quarto module #5820
Conversation
Armavica
force-pushed
the
quarto
branch
2 times, most recently
from
1b49064
to
00cb5b1
Compare
src/modules/quarto.rs
Outdated
| }) | ||
| .map(|variable| match variable { | ||
| "version" => { | ||
| let version = context.exec_cmd("quarto", &["--version"])?.stdout; |
There was a problem hiding this comment.
Please handle the trailing newline and update the command mocks to add it.
docs/config/README.md
Outdated
| | Variable | Example | Description | | ||
| | ------------- | --------- | ------------------------------------------------- | | ||
| | version | `1.4.549` | The version of `quarto`, alias for quarto_version | | ||
| | typst_version | `default` | The current Typst version | |
There was a problem hiding this comment.
I don't see anything parsing/filling that variable. Is this needed/wanted?
In any case: given that quarto bundles typst, what's the value in this, given that in most (or even all cases: can you overwrite the typst version by installing a newer version), the quarto version will determine the typst version?
There was a problem hiding this comment.
Indeed, that's a copy/paste fail. I removed the variable.
Armavica
force-pushed
the
quarto
branch
4 times, most recently
from
1f26e89
to
a3107aa
Compare
|
The commit and PR message is still mentioning Typst |
It was to credit the Typst module that I copy/pasted and adapted for this PR. But I can remove this mention if you want. |
davidkna
changed the title
|
LGTM, but please fix the conflicts. |
* Adapted from the Typst module
|
@davidkna Done! |
Description
I added a module for the Quarto publishing system on the model of the Typst module.
Motivation and Context
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: