Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Duration: Show decimals for seconds instead of rendering millis separately #5821

Closed
LionC opened this issue Mar 5, 2024 · 1 comment
Labels
✨ enhancement A new feature implementation.

Comments

@LionC
Copy link

LionC commented Mar 5, 2024

Feature Request

Describe the solution you'd like

Allow the cmd_duration module to show milis as fractional seconds instead of their own component,

Examples:

1.3s
15.7s
1m10.2s
0.4s

I actually expected this to happen when turning the show_milliseconds option on.

This is especially useful for commands that take <9s, where the difference between e.g. 2.9s and 2.1s is significant, but hard to scan when rendered as 2s900ms vs 2s100ms.

Considerations:

  • Should the precision rendered be configurable?
  • Should this (optionally) be turned off automatically for durations of >1min

I would be happy to implement this. If i followed the code path correctly, the render_time function responsible to do that is used by the aws module as well, so the feature could be exposed there as well if it makes sense.

EDIT:

Also noticed another possible inconsistency, opened a separate issue for it

@LionC LionC added the ✨ enhancement A new feature implementation. label Mar 5, 2024
@LionC
Copy link
Author

LionC commented Mar 8, 2024

Closed for more general solution

@LionC LionC closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature implementation.
Projects
None yet
Development

No branches or pull requests

1 participant