fix(nu): continuation prompt not being displayed correctly #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `starship` Most minimal changle possible. Other simplification are possible but not know to be backwards compatible. Also considered `with-env` or `STARSHIP_SHELL=nu starship` but they'd be worse. Happy to reformat indentation if desired.
texastoland
force-pushed
the
nushell-multiline-fix
branch
from
ff013f6
to
3d6226d
Compare
|
@davidkna bugfix 🙏🏼 |
|
Please do not ping me unwarrantedly. This PR has only been open for two days. |
andytom
approved these changes
Mar 20, 2024
andytom
changed the title
$env.STARSHIP_SHELL before calling starship
|
Thanks for the fix @texastoland, and thanks for reviewing @andytom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most minimal change possible. Other simplification are possible but not known to be backwards compatible. Also considered
with-envorSTARSHIP_SHELL=nu starshipbut they'd be worse. Happy to reformat indentation if desired.Motivation and Context
Closes #5847:
Screenshots (if appropriate):
How Has This Been Tested?
Tested locally by replacing my script and loading it both from my config as well as with
nu --no-config.Checklist: