Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(username): add aliases option #5855

Merged
merged 13 commits into from
Apr 5, 2024

Conversation

alper
Copy link
Contributor

@alper alper commented Mar 19, 2024

As described in #5784 a way to translate the displayed username into something else.

@alper alper marked this pull request as draft March 19, 2024 22:19
@alper alper marked this pull request as ready for review March 20, 2024 21:52
@alper alper force-pushed the add-username-alias-setting branch from dec2e2e to 4dd352a Compare March 20, 2024 22:00
@davidkna davidkna changed the title Add username aliases option feat(username): add aliases option Mar 27, 2024
Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andytom andytom merged commit 9c1eadd into starship:master Apr 5, 2024
21 checks passed
@andytom
Copy link
Member

andytom commented Apr 5, 2024

Thanks for your contribution @alper and thank you for reviewing @davidkna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants