refactor: Move ANSI escaping into its own functions #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipbuster
changed the title
|
LGTM if we can get the conflicts sorted out 👍 |
|
Oh....yeahhhhh 😅 So I tried to rebase this after the shell enum change, failed miserably, and somehow wound up with a pile of code that had merge conflict markers committed into it. I had planned to try again at some point, and I guess I just forgot. |
|
headdesk What the heck did I just do?? |
matchai
pushed a commit
that referenced
this pull request
Feb 6, 2020
dagbrown
pushed a commit
to dagbrown/starship
that referenced
this pull request
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves ANSI colorseq escape functionality into its own functions and adds tests.
Motivation and Context
One of the proposed changes in #865 involved escaping an ANSI code from within
print.rs. Currently, escaping these sequences is done inside of a closure insidemodule, which prevents it from being used elsewhere.This change allows us to escape unprintable characters from anywhere inside starship, as well as allowing a greater variety of escape sequences and tests specific to the escape parser (as opposed to just the module string generator).
Types of changes
Refactoring
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: