New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an Elm module #879
Conversation
I have tested this on macOS (screenshot), Linux (latest Fedora) and Windows. Unfortunately, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few minor corrections for the docs but in general LGTM, I'm not an Elm user so unable to test locally.
@andytom Thank you. Somehow I missed few lines to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An "elm"
entry is missing in src/configs/starship_root.rs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Thomas O'Donnell <andytom@users.noreply.github.com>
Co-Authored-By: Thomas O'Donnell <andytom@users.noreply.github.com>
@matchai I made the necessary changes to implement new tests (at least the tests are passing for this module). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Thank you for taking the time to update the tests.
@all-contributors Please add @m0nhawk for code, docs, and test. 🎉 |
I've put up a pull request to add @m0nhawk! 🎉 |
Former-commit-id: d421373
Description
elm.json
,elm-package.json
,elm-stuff
directory or*.elm
files.Motivation and Context
Closes #873
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: