Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port Haskell module tests to integration test #913

Merged
merged 16 commits into from Feb 6, 2020
Merged

feat: port Haskell module tests to integration test #913

merged 16 commits into from Feb 6, 2020

Conversation

m0nhawk
Copy link
Contributor

@m0nhawk m0nhawk commented Feb 6, 2020

Description

Port Haskell module to new test approach

Motivation and Context

Closes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@m0nhawk m0nhawk requested a review from matchai February 6, 2020 06:15
@matchai
chore(bump): v0.35.0
77a1cc2 
Former-commit-id: bc55166
@matchai
Copy link
Member

matchai commented Feb 6, 2020 •
edited

Excuse the mess. 🙏😣
I had to clean up a large file that was accidentally pushed to master.

Unfortunately it looks like the file is re-added in 4863bf9. I'll go ahead and remove it.

matchai
matchai approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍
Thank you for taking the time to update your tests! 😊

@matchai matchai changed the title feat: port Haskell module to integration test feat: port Haskell module tests to integration test Feb 6, 2020
@matchai matchai merged commit 77d61e1 into starship:master Feb 6, 2020
matchai pushed a commit that referenced this pull request Feb 6, 2020
@m0nhawk @matchai
test: port Haskell module tests to integration test (#913)
cead23e
@m0nhawk m0nhawk deleted the haskell-new-tests branch February 7, 2020 03:38
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
@m0nhawk @dagbrown
test: port Haskell module tests to integration test (starship#913)
bea5481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m0nhawk @matchai @chipbuster