Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cabal and hpack support to the haskell module #915

Merged
merged 4 commits into from Feb 7, 2020

Conversation

Brettm12345
Copy link
Contributor

Added support for cabal and hpack

@Brettm12345 Brettm12345 requested review from bijancn and heyrict and removed request for bijancn February 6, 2020 22:35
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍
Thank you for your contribution, @Brettm12345! 🎉

@matchai
Copy link
Member

matchai commented Feb 6, 2020

Oh whoops! Looks like we have some failing tests.
Should be ready to merge as soon as those are fixed. 😊

@Brettm12345
Copy link
Contributor Author

Fixed

@matchai matchai merged commit bc600e4 into starship:master Feb 7, 2020
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants