Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on ring breaks build on non-x86/ARM systems, even after going back to reqwest #933

Closed
q66 opened this issue Feb 12, 2020 · 0 comments · Fixed by #999
Closed
Labels
🐛 bug Something isn't working as expected.

Comments

@q66
Copy link

q66 commented Feb 12, 2020

It seems even after reverting the reqwest replacement (#844) there is still a dependency on ring right now. Running cargo tree indicates that it comes in via reqwest->hyper-rusttls->ct-logs->sct->ring.

It seems the reason for this is using rustls-tls feature for reqwest; removing it from features (leaving only blocking) fixes the problem.

There shouldn't be an issue building openssl on musl unless the vendored feature is used, which shouldn't generally be used, and I don't think it's used by default, as it uses openssl-sys with it...

Tried on 6 different PowerPC variants (64le/64/32, glibc and musl for each, ppc32/musl segfaults rustc but that's a compiler bug and seen elsewhere too fixed with rust 1.41) and it compiled fine on all of them. Also built on more conventional architectures like x86_64, with glibc and musl, in the Void Linux buildsystem.

@q66 q66 added the 🐛 bug Something isn't working as expected. label Feb 12, 2020
@q66 q66 changed the title Dependency on ring breaks build on non-x86/ARM systems Dependency on ring breaks build on non-x86/ARM systems, even after going back to reqwest Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant