Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower_components unnecessary #49

Closed
erayaydin opened this issue Mar 16, 2015 · 4 comments
Closed

bower_components unnecessary #49

erayaydin opened this issue Mar 16, 2015 · 4 comments

Comments

@erayaydin
Copy link

I think, bower_components will added to .gitignore file. Because its unnecessary. We can download this components with bower.json

@erayaydin
Copy link
Author

Also, a gruntfile will good for compiling components to dist

@challgren
Copy link
Contributor

Due to the way IronSummitMedia wants the repo to work. This is not a viable fix since bower_components needs to be included in the repo so the gh-pages can display the demo.

@davidtmiller
Copy link
Member

I may create a gulp task to copy dev dependencies to a vendor directory from bower_components (or node_modules because I'll be switching to npm here soon) so the dev dependencies will be included with the theme, but not alongside the template core files.

@davidtmiller
Copy link
Member

This is now taken into consideration. There's a vendor directory that has all of the third party dependencies in it. The bower_components directory was added to .gitignore and there is a new Gulp task to take the necessary dist files from bower_components and put them into vendor.

This removed a lot of unnecessary files that are included with the template.

Users can also run bower install if they want to pull the files in their own way, but the vendor library has everything that's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants