Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise repository to use date-based tags for repository and image releases #7

Closed
joeltimothyoh opened this issue Oct 14, 2021 · 11 comments · Fixed by #8
Closed

Revise repository to use date-based tags for repository and image releases #7

joeltimothyoh opened this issue Oct 14, 2021 · 11 comments · Fixed by #8
Assignees
Milestone

Comments

@joeltimothyoh
Copy link
Member

Based on #5 (comment)

@leojonathanoh
Copy link
Member

leojonathanoh commented Oct 15, 2021

@leojonathanoh
Copy link
Member

The workflow will be git checkout release && git merge --no-ff master && git push and that will be the automated release

@joeltimothyoh
Copy link
Member Author

I'm thinking keep it simple by adding a date tag followed by a push. @leojonathanoh

@leojonathanoh
Copy link
Member

leojonathanoh commented Oct 15, 2021

i agree and also prefer a simple approach because this repo generally is simple, so manually determining the tag is acceptable.

So it should be a master workflow:

  • master: docker builds for each push
  • tag: docker build with tag :latest
  • pull_requests build but no push.

@joeltimothyoh
Copy link
Member Author

I believe the rules for building are already taken care of. This issue was opened just so I can get to working on this change asap. I've got other repos based off the same release workflow so it wouldn't take long to sort this one out.

@leojonathanoh
Copy link
Member

please give an example of a workflow you have that meets criteria in the link in the OP

@leojonathanoh
Copy link
Member

i was thinking, that since this repo is really like theohbrothers/docker-*, where its really just a repo for building variants, it might as well go with the same workflow as all of them.

@joeltimothyoh
Copy link
Member Author

Unfortunately this is under startersclan and is strictly OSS with community contribution as the priority unlike many of the other image projects.

@leojonathanoh
Copy link
Member

leojonathanoh commented Oct 15, 2021

i'm working on a generic ci workflow config for both calver and semver that should work across all projects.

Unfortunately this is under startersclan and is strictly OSS with community contribution as the priority unlike many of the other image projects.

The theohbrothers/docker-* projects are also strictly open source. the workflow is identical. perhaps for this project there might not be a need for templating because of the few number of variants, but once variants are involved there needs to be some degree of templating.

@leojonathanoh
Copy link
Member

Managed to get a generic workflow for semver and calver: theohbrothers/docker-alpine#11

@joeltimothyoh
Copy link
Member Author

Closing.

@joeltimothyoh joeltimothyoh linked a pull request Oct 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants