Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build 10.0.17763.292 #645

Open
RoosterIllusion opened this issue Jan 19, 2019 · 40 comments
Open

Add support for build 10.0.17763.292 #645

RoosterIllusion opened this issue Jan 19, 2019 · 40 comments
Labels
add build Add new termsrv.dll build for support

Comments

@RoosterIllusion
Copy link

RoosterIllusion commented Jan 19, 2019

I am currently able to login by using the same offsets as 288 from here: #638 (comment)

I have only tested x64.

`;
;----------------------snip part1
[10.0.17763.292]
; Patch CEnforcementCore::GetInstanceOfTSLicense
LocalOnlyPatch.x86=1
LocalOnlyOffset.x86=AFAD4
LocalOnlyCode.x86=jmpshort
LocalOnlyPatch.x64=1
LocalOnlyOffset.x64=77A11
LocalOnlyCode.x64=jmpshort
; Patch CSessionArbitrationHelper::IsSingleSessionPerUserEnabled
SingleUserPatch.x86=1
SingleUserOffset.x86=4D665
SingleUserCode.x86=nop
SingleUserPatch.x64=1
SingleUserOffset.x64=1322C
SingleUserCode.x64=Zero
; Patch CDefPolicy::Query
DefPolicyPatch.x86=1
DefPolicyOffset.x86=4BE69
DefPolicyCode.x86=CDefPolicy_Query_eax_ecx
DefPolicyPatch.x64=1
DefPolicyOffset.x64=17F45
DefPolicyCode.x64=CDefPolicy_Query_eax_rcx
; Hook CSLQuery::Initialize
SLInitHook.x86=1
SLInitOffset.x86=5B18A
SLInitFunc.x86=New_CSLQuery_Initialize
SLInitHook.x64=1
SLInitOffset.x64=1ABFC
SLInitFunc.x64=New_CSLQuery_Initialize
;.------------------------------------
;

;
;.--------------------------snip part2
[10.0.17763.292-SLInit]
bInitialized.x86 =CD798
bServerSku.x86 =CD79C
lMaxUserSessions.x86 =CD7A0
bAppServerAllowed.x86 =CD7A8
bRemoteConnAllowed.x86=CD7AC
bMultimonAllowed.x86 =CD7B0
ulMaxDebugSessions.x86=CD7B4
bFUSEnabled.x86 =CD7B8

bInitialized.x64 =ECAB0
bServerSku.x64 =ECAB4
lMaxUserSessions.x64 =ECAB8
bAppServerAllowed.x64 =ECAC0
bRemoteConnAllowed.x64=ECAC4
bMultimonAllowed.x64 =ECAC8
ulMaxDebugSessions.x64=ECACC
bFUSEnabled.x64 =ECAD0
;.---------------------------
;`

@binarymaster
Copy link
Member

10.0.17763.292

@RoosterIllusion could you proof this build really exists? Post RDPConf screenshot.

@RoosterIllusion
Copy link
Author

image

image

Could be a version only for pro. I picked it up doing a repair install using the media creation tool having previously had .168, windows update wasn't offering the update at the time.

@binarymaster binarymaster added the add build Add new termsrv.dll build for support label Jan 19, 2019
@JigSawFr
Copy link

I've exactly the same version, not supported.

@binarymaster
Copy link
Member

No need to spam the issue with comments like that.

The problem is known and the ticket is open. You'll have to wait.

@JigSawFr
Copy link

No need to spam the issue with comments like that.

The problem is known and the ticket is open. You'll have to wait.

I do not wanted to spam this issue, but just confirm that release exist too on our side. :)

@DarkSector
Copy link

DarkSector commented Jan 23, 2019

Confirmed, .ini snippet provided by @RoosterIllusion works on v10.0.17763.292. Issue can be closed. Multiple concurrent connections allowed
screen shot 2019-01-22 at 4 04 34 pm

(Reboot required after .ini file is updated)

@devsk
Copy link

devsk commented Jan 23, 2019

How do we use this ini file? I don't see any such thing in the distributed ZIP.

@DarkSector
Copy link

@devsk add the snippet to the end of the .ini file and leave one blank line in the end.

@binarymaster
Copy link
Member

Issue can be closed.

@DarkSector no it can't, until the support is officially added.

@m333w
Copy link

m333w commented Jan 23, 2019

Hi all,

I have change the offset like @RoosterIllusion but i cant login with multiple session. Here is a capture of my problem : https://imgur.com/a/5ntaj4N

How i can solve my problem, please ?

@DarkSector
Copy link

Issue can be closed.

@DarkSector no it can't, until the support is officially added.

My bad, sorry.

@dcbasso
Copy link

dcbasso commented Jan 23, 2019

I really sorry to ask that, but I download the file "https://github.com/stascorp/rdpwrap/blob/master/res/rdpwrap.ini" and put in the unzip RDPwrap folder.
At the end of file I put the @RoosterIllusion code...
I install, update and etc... reboot and nothing fix the problem, still showing "[not supported]"...

What Im doing wrong?

@strarsis

This comment was marked as spam.

@OSAdministrator
Copy link

Thanks for this fix, i added the snips ad instructed to the ini file and everything lit up!
rdpwrapper-screenshot

@dcbasso
Copy link

dcbasso commented Jan 24, 2019

Thanks @strarsis! appears to be fix! Very easy...

@m333w
Copy link

m333w commented Jan 24, 2019

̷@̷O̷S̷A̷d̷m̷i̷n̷i̷s̷t̷r̷a̷t̷o̷r̷ ̷H̷i̷,̷ ̷
̷C̷a̷n̷ ̷y̷o̷u̷ ̷s̷e̷n̷d̷ ̷y̷o̷u̷r̷ ̷r̷d̷p̷w̷r̷a̷p̷.̷i̷n̷i̷ ̷f̷i̷l̷e̷ ̷p̷l̷e̷a̷s̷e̷ ̷?̷ ̷
̷
̷I̷ ̷h̷a̷v̷e̷n̷t̷ ̷s̷o̷l̷v̷e̷ ̷m̷y̷ ̷p̷r̷o̷b̷l̷e̷m̷ ̷(̷s̷c̷r̷o̷l̷l̷ ̷u̷p̷)̷ ̷s̷o̷ ̷i̷ ̷h̷a̷v̷e̷ ̷r̷e̷i̷n̷s̷t̷a̷l̷l̷ ̷a̷l̷l̷,̷ ̷b̷u̷t̷ ̷i̷ ̷n̷e̷e̷d̷ ̷t̷o̷ ̷e̷d̷i̷t̷ ̷t̷h̷e̷ ̷i̷n̷i̷ ̷w̷i̷t̷h̷ ̷t̷h̷e̷ ̷c̷o̷r̷r̷e̷c̷t̷ ̷i̷n̷f̷o̷r̷m̷a̷t̷i̷o̷n̷.̷
̷
̷B̷e̷s̷t̷ ̷r̷e̷g̷a̷r̷d̷s̷.̷

Edit: Woops i whas missing a line sorry for that...

Best regards.

@Igoricius
Copy link

Igoricius commented Jan 25, 2019

Hello to everybody. I updated rdpwrap.ini and everything looks perfect

image

but when I try to connect from another computer, I still have message "Another user is signed in...etc" Please, do you have any sugestion?

@joebeem
Copy link

joebeem commented Jan 27, 2019

Thanks for posting the solution to this issue.

I can confirm adding the snippets to the ini also worked for me on 10.0.17763.292.

Not sure if it was necessary to run the following exe commands, but I did this before modifying the ini.

rdpwinst.exe -u
rdpwinst.exe -i

After that, run cmd "net stop termservice", edit the ini to include snippets, and finally "net start termservice".

@Igoricius
Copy link

Thank you @joebeem for sharing your experience, but even that didn't helped me. I tried several times, even with fresh installation, but problem is still the same.
Configuration seems to be OK, but problem exists, as you can see in screenshots below.
I will be grateful for any help...

image

image

@vmc88
Copy link

vmc88 commented Jan 27, 2019

Same as above happened to me.

Fixed on restart.

@Maverick494
Copy link

This didn't work for me, even with restarting. I added the snippets to the .ini and I still get Not Listening.

Broken-RDPWrapper

What else do I need to check?

@rogerhanzhao
Copy link

same issue from me , how to fix it ? I think , one week ago , it was working!

@ditchmagnet
Copy link

Here is my rdpwrap.ini. This is working, just download and extract to your desktop. Follow these steps:

  1. Open CMD as Administrator
  2. net stop termservice
  3. Backup your rdpwrap.ini
  4. Copy and overwrite with my rdpwrap.ini (C:\Program Files\RDP Wrapper)
  5. Go back to the CMD Admin - net start termservice
  6. Check with RDPconf
    rdpwrap.zip

@jlipovac85
Copy link

Hello :) I updated rdpwrap.ini and everything looks perfect
image

but when I try to connect from another computer, I still have message "Another user is signed in...etc" Please, do you have any sugestion?

@ditchmagnet
Copy link

Does the problem go away when you uncheck "Single session per user" and "Apply"? What version of Windows are you on? 8.1? Server 2012?

@jlipovac85
Copy link

the problem is still the same
image
Windows version:
image

@Igoricius
Copy link

Igoricius commented Jan 28, 2019

It finally works!!! Thank you @ditchmagnet , your rdpwrap.ini was the solution. Please, explain us what is different in your configuration, because I used offsets @RoosterIllusion posted, but with no success.
Respect!

@Igoricius
Copy link

@jlipovac85 your OS version is not *292

@GitHub808user
Copy link

i'm getting what @Maverick494 is getting, the listener isn't listening. Same result when i append to the ini file or downloading the ini file that @ditchmagnet found. Tried restarting the termservice and reboot of the machine, nothing helps. Any ideas? I've verified that my dll file is on version 292

@RoosterIllusion
Copy link
Author

Do you guys have x86 windows? I have x64, so never tested x86. I don't know if anyone tested x86.

@jlipovac85
Copy link

Today everything works. The KB4476976 update was installed
RDPWRAP finally works

@a-skv
Copy link

a-skv commented Jan 29, 2019

windows 10 ver. 1809 build 17763.292
all done according to manuals
edited .ini
windows after reboot
RDPConf - all became green
Connecting by second user - "The number of connections to this computer is limited..."

upd
used .ini posted by @ditchmagnet - works

@jonasburneika
Copy link

@a-skv can you clarify witch Win10 version do you have? Pro or Home? Win10 Pro 1809 (OS Build 17763.292) and in my RDP folder .dll is not created :(

@arni7
Copy link

arni7 commented Jan 29, 2019

Welcome
strange thing after adding the entry from the first post
image

but printing works, after adding the @ditchmagnet file, everything works fine except printing
Please, do you have any sugestion?

@mixer-dm
Copy link

mixer-dm commented Jan 29, 2019

Hello.

I am simply not able to make it function. I have win 10 pro 17763.292 and everything is green as it should be. I installed the ini file following way. In the install folder i have the ini file prepared before typing rdowinst -i.
Everything is acitvated, i checked the ini file in the installation folder, it is the right modified one.
When i try to connect it disconnects the local user (lets call him user A) and the screen of the local user changes to the account i have connected to (user B).
I dont even get the message that someone will be disconected or that there are too many users. It simply disconnects user A.
It would be grateful for any suggestion.

PS: It acts like teamviewer

@ditchmagnet
Copy link

@mixer-dm sounds like it's working normally. You don't want to log out the current user? Did you uncheck "Single session per user" and "Apply"?

@mixer-dm
Copy link

mixer-dm commented Jan 29, 2019

Single session per user is unchecked, everything looks good (full green). Version is good. Account "user A" is logged. When account "user B" connects via remote desktop the screen of the logged "user A" turns to account "user B". Like Teamviewer. So both users (A+B) share one account.

After a clean new install of rdpwrapper i followed the instructions. Admin CMD, stop termservice, replace ini, start termservice, restarted windows unchecked "singe session per user" and still only one user possible.

Does the dll file also need to be updated sonehow ?

PS: Do i need to turn off windows defender while configuring everything ?

@ditchmagnet
Copy link

I don't think you need to update the dll, but here is the one from my RDP Wrapper installation folder. Single session and multiple session works fine for me. I think I did turn off defender (real time protection) during install since chrome was blocking it, I didn't want to risk it. So maybe do that and uninstall/reinstall rdp wrapper completely.

rdpwrap.zip

@mixer-dm
Copy link

mixer-dm commented Jan 30, 2019

Works great, thank you :)
I tried it on another computer (windows 10 installation with the same windows build version as the first computer) and it works.
I ll simply reinstall windows on the first computer and i am sure it ll work.
Thank you once again :)

PS: It worked instantly on the other ciomputer. Without any problem.

@Maverick494
Copy link

still have not listening. I am using ditch's ini and dll. I have rebooted, reinstalled, etc.

SvchostPushServiceGlobals
Loading configuration...
Configuration file: c:\program files\rdp wrapper\rdpwrap.ini
Initializing RDP Wrapper...
Base addr: 0x00007FFC6B180000
SvcMain: termsrv.dll+0x000000000002BFE0
SvcGlobals: termsrv.dll+0x000000000002C870
Version: 10.0.17763.292
Freezing threads...
Patch CEnforcementCore::GetInstanceOfTSLicense
Patch CSessionArbitrationHelper::IsSingleSessionPerUserEnabled
Patch CDefPolicy::Query
Hook CSLQuery::Initialize
Resumimg threads...
<<< SvchostPushServiceGlobals
ServiceMain
<<< ServiceMain
CSLQuery::Initialize
SLInit [0x00007FFC6B26CAB4] bServerSku = 1
SLInit [0x00007FFC6B26CAC4] bRemoteConnAllowed = 1
SLInit [0x00007FFC6B26CAD0] bFUSEnabled = 1
SLInit [0x00007FFC6B26CAC0] bAppServerAllowed = 1
SLInit [0x00007FFC6B26CAC8] bMultimonAllowed = 1
SLInit [0x00007FFC6B26CAB8] lMaxUserSessions = 0
SLInit [0x00007FFC6B26CACC] ulMaxDebugSessions = 0
SLInit [0x00007FFC6B26CAB0] bInitialized = 1
<<< CSLQuery::Initialize

that is the very last entry in the rdpwrap.txt

I can't think of anything else to do to get it to listen. If I have to I guess I can try and get a pro upgrade for cheap somewhere and see if Win10 Pro is easier to get this working.

@stascorp stascorp locked as too heated and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add build Add new termsrv.dll build for support
Projects
None yet
Development

No branches or pull requests