Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming issue with legacy WebRTC #67

Open
PITV420 opened this issue Apr 5, 2023 · 0 comments
Open

Naming issue with legacy WebRTC #67

PITV420 opened this issue Apr 5, 2023 · 0 comments

Comments

@PITV420
Copy link

PITV420 commented Apr 5, 2023

Hi! So this week I tried to wrap up custom audio engine and audio unit (AVAudioEngine and AVAudioUnit) to be compatible with LiveKit situation and unfortunately, the single one file in this wrapper, called RTCAudioDevice.h cause a conflict with legacy WebRTC (Specs for Swift language to be specific) and does not allow to use this repo with LiveKit situation. Also it turned out that rebuilding framework with custom name is so slow and is too much of a headache then tailoring RTCAudioDevice and corresponding ObjC file in WebRTC. Please check on this issue and if that wouldn't be much of an issue and won't break multiple repos that uses this one, it might be worth it changing naming or at least give moduleAlias in the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant