Use getSearchReference method instead of reference
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue for me. Without this I am not able to save the resource. |
|
@duncanmcclean I can't really maintain this anymore because my company moved from MeiliSearch to Elastic. Would you or Statamic like to take it over and help maintain it? |
|
@tao It might be worth opening up an issue that you're looking for a maintainer (maybe update the README, too?). I, for one, hope someone can keep this running (even if it's not @duncanmcclean or the Statamic team), as good search integration is something Statamic sorely needs (and this works great!). It doesn't even have to be expanded, just kept functional. PHP's not my strong suit, otherwise I'd offer. |
|
Just as an update: we're planning on moving this add on into the Rad Pack this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull replace replaces the usage of the
referencewithgetSearchReferencein thedeletemethod.This change reflects changes made to the Core Algolia driver as part of the search overhaul made a few major updates ago:
Before:
https://github.com/statamic/cms/blame/07fe80daea2096538b419d58cd1744ebbd980c0b/src/Search/Algolia/Index.php#L47
After:
https://github.com/statamic/cms/blame/6ec5a2f107a8834e6d225f2ba44c10c283c058b7/src/Search/Algolia/Index.php#L47
I'll admit I haven't tested these changes locally but I believe it should resolve the issue from someone using one of my addons, after source diving.
Fixes statamic-rad-pack/runway#345.