Specify a high maxTotalHits and hitsPerPage to avoid pagination issues #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
Oct 17, 2023
ryanmitchell
added a commit
to ryanmitchell/statamic-meilisearch
that referenced
this pull request
Dec 8, 2023
commit 2616097 Author: Duncan McClean <duncan@duncanmcclean.com> Date: Mon Nov 27 11:16:32 2023 +0000 Changelog commit 3473720 Author: Ryan Mitchell <ryan@thoughtcollective.com> Date: Mon Nov 27 11:14:28 2023 +0000 Support site based indexes (statamic-rad-pack#29) commit 416ad1c Author: Duncan McClean <duncan@duncanmcclean.com> Date: Thu Nov 2 12:14:45 2023 +0000 Changelog commit cc044a3 Author: Duncan McClean <19637309+duncanmcclean@users.noreply.github.com> Date: Thu Nov 2 12:12:17 2023 +0000 Make use of Meilisearch sorting (statamic-rad-pack#27) * Make use of ranking score from Meilisearch * Return collection * Move `->map()` into Query This matches where the search score is set in the Algolia driver. --------- Co-authored-by: Robert <robert@codepeak.se> commit 644e81a Author: Duncan McClean <duncan@duncanmcclean.com> Date: Tue Oct 17 09:31:29 2023 +0100 wip commit 2ee612f Author: Duncan McClean <duncan@duncanmcclean.com> Date: Tue Oct 17 09:29:51 2023 +0100 Changelog commit 1b5fd77 Author: Ryan Mitchell <ryan@thoughtcollective.com> Date: Tue Oct 17 09:25:30 2023 +0100 Specify a high maxTotalHits and hitsPerPage to avoid pagination issues (statamic-rad-pack#24) * Fix pagination issues * Fix tpyo --------- Co-authored-by: Duncan McClean <duncan@duncanmcclean.com> commit 6c21d26 Author: Duncan McClean <duncan@duncanmcclean.com> Date: Tue Oct 17 08:36:12 2023 +0100 Changelog commit ed81ffe Author: Ryan Mitchell <ryan@thoughtcollective.com> Date: Tue Oct 17 08:33:26 2023 +0100 Fix naming issues (statamic-rad-pack#23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CP search handles pagination internally so specify a high hitsPerPage and maxTotalHits to allow it to get a full result set then do its own thing from there.
I set these as config variables so a developer can override this if they want.
Closes #16