Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial comments on JOSS submission #138

Closed
osorensen opened this issue Dec 7, 2022 · 6 comments
Closed

Editorial comments on JOSS submission #138

osorensen opened this issue Dec 7, 2022 · 6 comments
Assignees

Comments

@osorensen
Copy link

osorensen commented Dec 7, 2022

I'm reading through the JOSS submission, and will post comments as issues in the repository.

My first comment is what you write on lines 66-67: "In the following example, we use regress to fit a linear regression model of atrophy (a measure of global brain activity assessed using MRI) on sex, weight, age, and race."

The part in the parentheses does not seem correct, since atrophy in fact is a measure of tissue loss.

There are a few more things I don't understand about the example application starting on line 62:

  • Is the atrophy measured by volume, area, or thickness?
  • Is it cortical atrophy, averaged over the cerebral cortex, or does it also include subcortical volumes?
  • Atrophy is a measure of change, but estimating change requires at least two timepoints. What is then actually represented by the variable atrophy in the mri dataset?

I looked this up in the Kuller et al. (2007), and I wonder if what is actually represented by the atrophy variable is white matter grade? Could you please clarify, and if necessary update both the paper and the mri example dataset?

@yiqunchen
Copy link
Collaborator

Thanks for your detailed read and clarification! The MRI dataset was originally derived from Kuller et al. (2007) but has been adapted for the use of this package.

In this case, atrophy is measured by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy.

We have clarified the text in the submission as follows:

In the following example, we use regress to fit a linear regression model of atrophy (a measure between 0 and 100 of global brain activity measured by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

Please let us know if you have any other questions; thank you again for your thorough review!

@osorensen
Copy link
Author

Thanks for addressing this issue!

I'm still not completely on board, however, since the text still suggests that atrophy is a measure of global brain activity, which it is not.

I suggest rewriting to the following:

In the following example, we use regress to fit a linear regression model of atrophy (a measure between 0 and 100 of loss of neurons estimated by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

See, e.g., here or here.

@yiqunchen
Copy link
Collaborator

Thank you for your great suggestion! In this revision (3ccb5a2), we have edited the sentence to:

In the following example, we use regress to fit a linear regression model of atrophy (a measure of loss of neurons estimated by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no atrophy and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

We really appreciate your reviews!

@osorensen
Copy link
Author

Great! Could you please also update the documentation of the atrophy variable in mri dataset accordingly?

That is, here:

rigr/R/data.R

Line 95 in 0d5f6eb

#' \item{atrophy}{a measure of global brain activity detected on MRI.

@yiqunchen
Copy link
Collaborator

Thank you for your suggestion -- it has been revised accordingly in https://github.com/statdivlab/rigr/blob/main/R/data.R#:~:text=%27%20%5Citem%7Batrophy%7D%7Ba,degree%20of%20atrophy.%7D

@osorensen
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants