Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Default cube scene can't be composed properly #160

Closed
Zman350x opened this issue Jan 29, 2022 · 8 comments · Fixed by #161
Closed

[BUG] Default cube scene can't be composed properly #160

Zman350x opened this issue Jan 29, 2022 · 8 comments · Fixed by #161
Assignees
Labels
bug Something isn't working

Comments

@Zman350x
Copy link

Issue description:

As I'm rendering over BlendNet (local provider), I'm getting "E:100:00%" instead of "COMPLETED" by each task. It's also taking way longer than I'd expect given the number/power of local agents. I've tried with 14 agents over WiFi, which never even got to the point where each task said "E:100:00%," most likely due to network issues. I've also tried with 3 agents over Ethernet, which at least completed all tasks with the "E:100:00%" error.

Environment:

  • Application version: v0.3.10
  • Blender client version: v3.0.0
  • Blender worker version: v3.0.0
  • OS: Windows 10 Home x64 version 2004 (on all PCs)

Steps to reproduce:

Steps to reproduce the behavior:

  1. Run Blender
  2. Keyframe default cube's z-rotation to 0 on frame one. Keyframe it to 720 on frame 250 (final frame).
  3. Setup the add-on
  4. Start manager & local agent scripts
  5. Hit "Run Animation Tasks"
  6. Wait for forever
  7. Get errors

Expected behavior

Doesn't take too long to render, given it's a spinning default cube w/ multiple machines-worth of power. When it's done I have a series of PNGs or video, not a bunch of tasks with errors.

Screenshots

If applicable, add screenshots to help explain your problem.
image
image
image
image

Additional context

https://www.toptal.com/developers/hastebin/udixokivur.yaml
logthing.txt (too big to just do a hastebin link)

@Zman350x Zman350x added the bug Something isn't working label Jan 29, 2022
@rabits
Copy link
Member

rabits commented Jan 30, 2022

Yeah, it's some sort of logic issue:

22.01.28 01:53:04.660000	  Traceback (most recent call last):
22.01.28 01:53:04.660000	    File "<string>", line 1, in <module>
22.01.28 01:53:04.660000	    File "C:\Users\Photon\Documents\dist\blendnet\BlendNet\script-compose.py", line 85, in <module>
22.01.28 01:53:04.660000	      image_node.layer = 'View Layer'
22.01.28 01:53:04.660000	  TypeError: bpy_struct: item.attr = val: enum "View Layer" not found in ('ViewLayer')

The script which tries to compose the result out of the rendered pieces fails... Need to check closely.

@rabits rabits changed the title [BUG] [BUG] Default cube scene can't be composed properly Jan 30, 2022
@rabits
Copy link
Member

rabits commented Jan 30, 2022

Working on reproducing the issue - so regarding the slowness, by default Blender v3 switched from "strict number of samples to render" to "noise threshold", means it tries to determine amount of noise in the scene and stop render when it hit the specific value. That leads to 1024 samples to render for a single cube in Blendnet, because it's nature to distribute the tasks by strict samples over the nodes and it can't calculate the noise threshold due to it's distributed architecture.

So the easy answer to that is not to use "noise threshold", the hard answer will be to change the Blendnet architecture to deal with this kind of workload and distribute as one frame per node. Unfortunately right now the task that should address this issue is quite stalled (#90), so not sure when I will rewrite the engine of Blendnet to support that.

@rabits
Copy link
Member

rabits commented Jan 30, 2022

Ok, just reproduced locally - that's a bug for sure.

@rabits rabits self-assigned this Jan 30, 2022
@rabits
Copy link
Member

rabits commented Jan 30, 2022

Looks like v3 uses by default "ViewLayer" instead of "View Layer" as a name. Created a fix for that.

@rabits rabits linked a pull request Jan 30, 2022 that will close this issue
@rabits
Copy link
Member

rabits commented Jan 30, 2022

Will fix it for master and then move to v0.3

@Zman350x
Copy link
Author

@rabits I go to work on Tuesday, I'll try it then!

@rabits
Copy link
Member

rabits commented Jan 31, 2022

Thank you, and I would recommend to start small - like one manager + one agent + one image task and gradually move to bigger installations (2 agents + animation tasks, 4 agents and some real project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants