Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "exit format" to "standard outcome" #31

Closed
geoknee opened this issue Jun 23, 2021 · 2 comments
Closed

change "exit format" to "standard outcome" #31

geoknee opened this issue Jun 23, 2021 · 2 comments
Assignees

Comments

@geoknee
Copy link
Contributor

geoknee commented Jun 23, 2021

[NEW] What is this issue for
Decide on a naming convention that reduces confusion in the statechannels repos (primarily, for now).

[Defined] How will we solve it
A clear and concise description of what you want to happen, which can include implementation suggestions
Include an estimate (~ 1point = 1day)

[Development]
[] This ticket has clearly outlined the expected outcome, and I can complete this ticket with no additional refinement

Additional context Add any other context or screenshots about the feature request here: notion doc, github discussion or ticket

@NiloCK NiloCK self-assigned this Jul 8, 2021
@geoknee
Copy link
Contributor Author

geoknee commented Jul 22, 2021

We like the idea of keeping the naming as is, and aliasing the imports on the consuming side. This is easy to do in Typescipt.

Question: is it also possible in solidity? for example:

import {ExitFormat as StandardOutcome} from '@statechannels/exit-format/contracts/ExitFormat.sol';

@geoknee
Copy link
Contributor Author

geoknee commented Jul 22, 2021

We think the answer is yes

https://docs.soliditylang.org/en/v0.4.24/layout-of-source-files.html

so closing this issue.

@geoknee geoknee closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants