Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nitro-specific) convert claim and transfer to operate at the single asset level #48

Closed
geoknee opened this issue Jul 22, 2021 · 0 comments · Fixed by #62
Closed

(nitro-specific) convert claim and transfer to operate at the single asset level #48

geoknee opened this issue Jul 22, 2021 · 0 comments · Fixed by #62
Assignees

Comments

@geoknee
Copy link
Contributor

geoknee commented Jul 22, 2021

[NEW] What is this issue for
We want to integrate the exit format into nitro-protocol. The current contract API for the latter allows for "per asset" transactions.

The pure functions in this repo currently loop over all assets. This is bad because

  • we want to allow for finer-grained payouts
  • it doesn't make sense to specify a single guaranteeIndex for all assets

[Defined] How will we solve it

Assume that we have already drilled into a given asset for both channels. In fact, write (or port) pure functions that operate per-asset called computeNewAllocation and computeNewAllocationsWithGuarantee.

[Development]
[] This ticket has clearly outlined the expected outcome, and I can complete this ticket with no additional refinement

Additional context Add any other context or screenshots about the feature request here: notion doc, github discussion or ticket

@geoknee geoknee self-assigned this Jul 22, 2021
@geoknee geoknee changed the title (nitro-specific) convert claim and transfer to accept an asset index (nitro-specific) convert claim and transfer to operate at the single asset level Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant