Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect (passing) assertion in claim.test.ts #51

Closed
geoknee opened this issue Jul 26, 2021 · 0 comments · Fixed by #62
Closed

Incorrect (passing) assertion in claim.test.ts #51

geoknee opened this issue Jul 26, 2021 · 0 comments · Fixed by #62
Assignees

Comments

@geoknee
Copy link
Contributor

geoknee commented Jul 26, 2021

This test case involves a guarantee (A,I,B) , funded with 10 coins, allocating all 10 coins to a target channel itself having outcome (A:5,B::5,I:10). It seems clear that the guarantee cannot afford any coins for Bob. Yet the test asserts that he can get 5 coins:

const claimResult2 = claim(guarantee, initialHoldings, 0, initialOutcome, [
[1],
]);
expect(claimResult2.updatedTargetOutcome).to.deep.equal(
createOutcome([
["A", "0x05"],
["B", "0x00"],
["I", "0x0A"],
])
);
expect(claimResult2.exit).to.deep.equal(createOutcome([["B", "0x05"]]));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant