Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook layout #16

Open
czebe opened this issue May 22, 2019 · 1 comment
Open

Storybook layout #16

czebe opened this issue May 22, 2019 · 1 comment

Comments

@czebe
Copy link

czebe commented May 22, 2019

Including the visualizer in Storybook (which would be the natural place as it's a living documentation) looks pretty bad. It works fine, but styling is all over the place. It's not really possible to override styles/apply theming as it's using styled components:

image

What would be the best approach to make it embeddable in various places and avoid CSS conflicts with host styles?

@davidkpiano
Copy link
Collaborator

Use an iframe? Or open it up in a separate window. That storybook's styles leak is completely their fault, and not the responsibility of the visualization component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants