Interactive inputs do not produce "echo"

[sourishkrout]

Simple example is running read. Unclear what needs to toggle whether or not echoing is enabled. Might have to do some digging in Runnerv1.

config:{program_name:"/bin/zsh" directory:"/Users/sourishkrout/Projects/stateful/oss/vscode-runme/examples" env:"RUNME_ID=01HX7QEZTB94V7A28K766WNRG3" env:"TERM=xterm-256color" commands:{items:"read" items:""} interactive:true mode:COMMAND_MODE_INLINE known_id:"01HX7QEZTB94V7A28K766WNRG3"} winsize:{rows:10 cols:177} session_id:"01HX7QGJ4VNB9YYEC3NCHD908M" store_stdout_in_env:true

runme/internal/command/command_virtual.go

Lines 98 to 100 in e163a3a

	if err := disableEcho(c.tty.Fd()); err != nil {
	return err
	}

[adambabik]

It's disabled by default:

runme/internal/command/command_virtual.go

Lines 98 to 100 in e163a3a

	if err := disableEcho(c.tty.Fd()); err != nil {
	return err
	}

Should it be enabled or configurable?

[sourishkrout]

Should it be enabled or configurable?

I wish I could remember the logic because it wasn't just always on or always off. Do you see anything in the runnerv1 implementation that's revelatory?

@adambabik when you search for DisableEcho it appears that the echo is enabled when a TTY is attached which is always true for a VirtualCommand, no?

[adambabik]

I wish I could remember the logic because it wasn't just always on or always off. Do you see anything in the runnerv1 implementation that's revelatory?

In the runnerv1 service, echo is always enabled. When using the CLI, executing a program which is a file or shell, and the block is marked as interactive, which is a default, then echo is disabled. I am not sure if it was well thought out, but the fact is that in runnerv2 echo is always disabled. Should I flip it to stay compatible?

@adambabik when you search for DisableEcho it appears that the echo is enabled when a TTY is attached which is always true for a VirtualCommand, no?

This is true and VirtualCommand is used when the block is interactive, which is a default.

[sourishkrout]

@sourishkrout yes, let's go ahead and flip it please. Being "incompatible" otherwise means the integration with the notebook terminal stops working as expected.

[adambabik]

@sourishkrout I merged #576. Let me know if there is anything else that should be done as a part of this ticket.

[sourishkrout]

@sourishkrout I merged #576. Let me know if there is anything else that should be done as a part of this ticket.

This looks good now 👍 . Thank you!