Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependencies #30

Closed
NixBiks opened this issue May 27, 2021 · 1 comment · Fixed by #32
Closed

Unnecessary dependencies #30

NixBiks opened this issue May 27, 2021 · 1 comment · Fixed by #32

Comments

@NixBiks
Copy link
Collaborator

NixBiks commented May 27, 2021

In setup.cfg the following dependencies are listed

ipython>=6
nbformat>=4
nbconvert>=5
requests>=2

Isn't that a mistake?

I also see Js2Py being used in scxml.py but only listed in requirements_dev.txt. That seems wrong as well.

Let me know if any of this is intended and then I'll fix in a PR.

@davidkpiano
Copy link
Member

The setup.cfg dependencies look wrong to me, too. And yes, Js2Py should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants