Fixed compatibility with Skypack #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95ac8d9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95ac8d9:
|
Andarist
commented
Feb 24, 2022
| } from 'xstate'; | ||
| import { XStateDevInterface } from 'xstate/lib/devTools'; | ||
| import { toSCXMLEvent, toEventObject, toObserver } from 'xstate/lib/utils'; |
There was a problem hiding this comment.
Such changes should be OK as per our semver policy: https://github.com/statelyai/xstate/tree/50c271dc1a1a05b035364f8247aa4d80d613864f#packages-1
davidkpiano
approved these changes
Feb 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, I just removed
keysas we can easily useObject.keys. I've also inlinedflatteninto other packages since it's a one-liner.Other things that caused "deopts" were moved to the root entry of XState, you can check out what exports have been added