Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tooltip content flow around close button (x) #93

Closed
pjvandehaar opened this issue Mar 13, 2017 · 1 comment
Closed

Let tooltip content flow around close button (x) #93

pjvandehaar opened this issue Mar 13, 2017 · 1 comment

Comments

@pjvandehaar
Copy link
Contributor

pjvandehaar commented Mar 13, 2017

PR #94

@Frencil Frencil changed the title Let tooltip content flow around x Let tooltip content flow around close button (x) Mar 13, 2017
@Frencil
Copy link
Contributor

Frencil commented Mar 13, 2017

This may be a bit harder than it seems - tool tip close buttons are absolutely positioned along with the tool tip itself as an overlay after the tool tip is rendered. This approach was taken instead of floating the close button because the button is a part of the tool tip body, not its content. To accommodate this, when a tool tip is closeable the right padding is upped to provide space.

I'd be hesitant to rework the button to be a floated element because it would then have to work with any arbitrary tool tip content, and that can lead to breaking the button display much easier. As is, you can hand just about any HTML to a tool tip and the close button will appear where it should.

An alternative, if the extra width on tool tips for the close button is undesirable, the close button could hang off the edge of the tool tip? Can you provide a use case where close buttons as-is present a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants