You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously I mentioend that it is a pity (not necessarily a bug) that Pheweb could not find rsIDs for SNPs simply because their A1/A2 alleles are not the same as the REF/ALT allele. I said that this idea of a single REF/ALT allele in the "reference genome" will be abandoned, because now there are more and more genomes in the reference.
I just took a look at your add_rsids.py code. Even though I had no experience in python programming, I believe that only one line will fix this issue. As shown in the following screenshot, I think we simply need to add or (cpra['ref'] == rsid['alt'] and are_match(cpra['alt'], rsid['ref'])) to the end of line 140.
I feel that updating this line is really important. Also, it would be good to be case insensitive, so that a/c is equal to A/C.
Best regards,
Jie
The text was updated successfully, but these errors were encountered:
Dear Peter and guys:
Previously I mentioend that it is a pity (not necessarily a bug) that Pheweb could not find rsIDs for SNPs simply because their A1/A2 alleles are not the same as the REF/ALT allele. I said that this idea of a single REF/ALT allele in the "reference genome" will be abandoned, because now there are more and more genomes in the reference.
I just took a look at your add_rsids.py code. Even though I had no experience in python programming, I believe that only one line will fix this issue. As shown in the following screenshot, I think we simply need to add or (cpra['ref'] == rsid['alt'] and are_match(cpra['alt'], rsid['ref'])) to the end of line 140.
I feel that updating this line is really important. Also, it would be good to be case insensitive, so that a/c is equal to A/C.
Best regards,
Jie
The text was updated successfully, but these errors were encountered: