New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocketconnections in limbo #223

Closed

notgiven688 opened this issue Apr 14, 2018 · 0 comments

Contributor

notgiven688 commented Apr 14, 2018

Hi there,
I am too stupid/lazy to actually create a pull request. Here is the code which I want to discuss (diff it to the original file) https://github.com/notgiven688/Fleck/blob/master/Fleck/WebSocketConnection.cs

I noticed - in a real world situation - that instances of WebSocketConnection classes are created, but OnOpen() and OnClose() never gets called. This results in a memory leak. I added a timeout here https://github.com/notgiven688/Fleck/blob/03fcca155cc3afeaf74f36b1e8f9a5c389d71e7f/Fleck/WebSocketConnection.cs#L113 which seems to fix the problem.

Any insights what is happening here?

statianzo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment