Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Client Close Messages Properly #35

Open
statianzo opened this issue Jan 18, 2012 · 3 comments
Open

Handle Client Close Messages Properly #35

statianzo opened this issue Jan 18, 2012 · 3 comments
Labels
RFC Compliance
Milestone
1.0

Comments

@statianzo
Copy link
Owner

Currently, close messages are not handled according to spec.
@codemasta92
Copy link

I has rewritten the ProcessFrame method in Hybi13Handler.cs, which fixes most FAILs in section 7 (except for case 7.5.1). The code can be found here https://gist.github.com/1638952

@statianzo
Copy link
Owner Author

Nice. I'll take a look at getting this behavior tested and brought in.

@statianzo
Copy link
Owner Author

Wrote some tests and brought it in. Also doing UTF8 validation on all close payloads > 2 bytes to make 7.5.1 pass.

7.1.5 is still not right so i'm keeping this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Compliance
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@statianzo @codemasta92