Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored partials that are used as plugin templates don't trigger the watcher #40

Closed
cearls opened this issue Nov 28, 2016 · 2 comments
Closed

Comments

@cearls
Copy link

cearls commented Nov 28, 2016

I'm using an ignored view (views/_page.sgr) as a plugin template and changes to this file aren't triggering the watcher.

@jescalan commented in gitter: so ignored files are ignored by the watcher unless they are added to webpack as dependencies of files

@jescalan
Copy link
Member

jescalan commented Dec 2, 2016

Ok so I have been thinking about how we might be able to work this out. The issue is that spike typically tries to only recompile the files that are needed during the watch, and has a map itself of which files depend on which other files. However, the templates generate output independent of other files in the project, and plugins decide on the output they generate. So I'm not entirely sure what spike will do even if they are added to the watcher, but we shall see.

This line should enable us to add the template files to the watcher manually, going to test with this and see if this resolves the issue:

https://github.com/static-dev/spike-core/blob/master/lib/config.js#L150

@jescalan
Copy link
Member

jescalan commented Aug 3, 2017

Ok so this has been solved with the latest round of updates to how single page templates are handled. The architecture change has been made and published to spike-datocms and spike-contentful. 🎉

@jescalan jescalan closed this as completed Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants