Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Known problem with BLAST module]500+ results gives no output in blast #199

Closed
bradfordcondon opened this issue Feb 27, 2018 · 7 comments
Closed
Assignees
Labels

Comments

@bradfordcondon
Copy link
Contributor

The user experienced an error that there were 500 + results. Even tightening the evalue gave this error: i suspect that it is not a blast issue but a bug in the module.

@bradfordcondon
Copy link
Contributor Author

Also, if there are 500 + results, why not just skim the top 20 and return those?

@bradfordcondon
Copy link
Contributor Author

bradfordcondon commented Feb 27, 2018

Sequences are below to troubleshoot. Meg has verified setting a reasonable e value should not give 500+ results.


>54Downstream-Mine_F12.ab1
NNNNNNNNNNNNNNNNNNNNNCANNAANGTGACAGANTAGCTTGGGCAANGGAANNCCGAAGGAAGGTTNNCGGATATTACCCTTNGTTGAAAAGTCTCAATTGCCCTTTGGTCTTCTGAGACTGTATCTTTGATATTTTTGGAGTAGACAAGTGTGTCGTGCTCCACCATGTTGACCTCTGCAGGCATGCAAGCTTCTGTTAACTTGCTAGCTTCTGCAGGTACCTTAATTAAAAGTTTAAACTATCAAGTGACTGCATATACGTTCCTGCACCAACTTTGGCAAAGAAAAGGCAACCCACTTCATCATGTGAAGAATGCTGACTATCACCACTAATGGAAACTAATGGAAGATTTGGACAAGCCAGGACGCCCAACACTACTTTCCCTTCATCTAGCAATCCCAGTGCTATAGCATATTGGTCTCCTCTTAGAAATCTATTACAAAATATGAAGCACTCAATTGACAAGTGAATGCATAAAAAAAATAAGCACTCGGTTGACAAGTGAATCATTGATAAAATATATAAATCAGCAAATAGAAAGTACAAAACAAAGCAATGAAAAAGGAAGTTTCGCCAAAGAGAGTTAGCGACCACTGATTTTTGTCTAGTTCCTTAAGTCTTCTAAACGTACTTCATTTCCTATCACAATGCNACACNCTNNNNNNNANNNNAAA
>58Upstream-Mine_G12.ab1
NNNNNNNNNNNNNNNNCTGACCGCTTCCTCGTGCTTTACGGTATCGCCGCTCCCGATTCGCAGCGCATCGCCTTCTATCGCCTTCTTGACGAGTTCTTCTGAGGGATCGTTCAAACATTTGGCAATAAAGTTTCTTAAGATTGAATCCTGTTGCCGGTCTTGCGATGATTATCATATAATTTCTGTTGAATTACGTTAAGCATGTAATAATTAACATGTAATCTTGTTTCTTTTATCAAAAGGTATACATGTGTAGGTTTTAATGTTTTATAAATCGAATGAAGAAAGTCAAATAATGTAAAAGAGAAAAACAAGAGCAATGGTTTTAATATAATTCGATTTCACGGTCGACCCATGTCCACACCCAAAAATAAAATAAATAAATAAAATCCAAAAAACCTAAATTTTTATGATTCTAAATTATTTTTGTATGTTACAATGAAACCGTGCACGCAAGTAGACATGGCAAAACGAGTTGGGATTCACCAACCTGACCCAAATCCAAAGGAAAATATTTGATCCAAATCTGATTTTTTGACCCGAATATAAAACAAGTTGACCTGTGACCTGACCNNNCCCNNNNNNNNAANNN
>58Downstream-Mine_H12.ab1
NNNNNNTNNNNTCTTCNCATAAAGTGACAGATAGCTGGGCAATGGAATCCGAGGAGGTTTCCGGATATTACCCTTTGTTGAAAAGTCTCAATTGCCCTTTGGTCTTCTGAGACTGTATCTTTGATATTTTTGGAGTAGACAAGTGTGTCGTGCTCCACCATGTTGACCTCTGCAGGCATGCAAGCTTCTGTTAACTTGCTAGCTTCTGCAGGTACCTTAATTAAAAGTTTAAATGCATGTTAAGAGCATACAGAACATGTGATTCAATGGTTGAATTTTCAAAATATAGATTCAATAAATTATTAAGTACATCCAATTGGCATGAAAATTGGCATGCATATTAAGAATATATAGAACATATGATTCAACAGTTGAATTTTCAAAATATAAATTCAATAACAAGTTATTGGATGATGTAACATATAATGTCATTCAAATACAATGGCNNNNNNAAAGCAAA

we're talking about the bottom sequence, >58Downstream-Mine_H12.ab1

@bradfordcondon
Copy link
Contributor Author

default blast parameters: error, 500+ sequences

screen shot 2018-02-27 at 11 58 01 am

evalue of 0.00000000001, max target = 50

screen shot 2018-02-27 at 12 00 07 pm

e value: 0.00000000001 no max target

screen shot 2018-02-27 at 12 03 40 pm

@bradfordcondon
Copy link
Contributor Author

Created an issue in the module to resolve tripal/tripal_blast#25

I think the ideal behavior is obvious: display the first 500 results. (realistically the first 50 results...)

@bradfordcondon
Copy link
Contributor Author

bradfordcondon commented Feb 27, 2018

Secondary issue with #203

Setting the max number of hits to 250 instead of 50 puts you somewhere between. at 500, the module cuts users off. at 50, theres no problem. at 250, the module allows the request to run, and i believe the server runs out of memory, ie, we experience the problem that Lacey put in the failsafe to prevent in tripal/tripal_blast#12.

Solutions

temporary

  • Change the cutoff in the code from 500 to 101

Long term

  • Reimplement how they read in the xml in the module itself, see Lacey's issue on the module

@bradfordcondon bradfordcondon changed the title 500+ results gives no output in blast [Known problem with BLAST module]500+ results gives no output in blast Feb 27, 2018
@bradfordcondon
Copy link
Contributor Author

hard coded solution:

default:

? $options['max_target_seqs'] : 500; changed to 50

options: remove 250, 500 +

Done on dev, testing

@bradfordcondon
Copy link
Contributor Author

changes made live as well.

What I should do is change the admin form to accept an array of choices...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant