Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force escape cubeAlias to work with restricted column names #128

Merged
merged 3 commits into from Jun 9, 2019

Conversation

dgkm
Copy link
Contributor

@dgkm dgkm commented Jun 6, 2019

force escape cubeAlias to work with restricted column names such as "case" in the column name

@paveltiunov
Copy link
Member

@dgkmurthy Hey Keshava! Thanks for contributing this one! Just checked: it fails tests. Could you please fix it?

@dgkm
Copy link
Contributor Author

dgkm commented Jun 7, 2019

@dgkmurthy Hey Keshava! Thanks for contributing this one! Just checked: it fails tests. Could you please fix it?

@paveltiunov, I will double check. Any particular test scenarios you are referring to?

@paveltiunov
Copy link
Member

@dgkmurthy It's filter join not multiplied and MongoDB tests.

@dgkm
Copy link
Contributor Author

dgkm commented Jun 8, 2019

@dgkmurthy It's filter join not multiplied and MongoDB tests.

@paveltiunov As of now I can only test again Postgres. I have reverted changes and applied to only Postgres Query part. Can you please check?

@paveltiunov
Copy link
Member

paveltiunov commented Jun 8, 2019

@dgkmurthy Hey Keshava! Actually your first change was correct. You just need to fix this line: https://github.com/statsbotco/cube.js/blob/d22a809059340e2b7caab7dc8cb122c14e581edd/packages/cubejs-schema-compiler/adapter/BaseQuery.js#L589 There's double escaping.

removed the double escaping of cubeAlias
@dgkm
Copy link
Contributor Author

dgkm commented Jun 8, 2019

@dgkmurthy Hey Keshava! Actually your first change was correct. You just need to fix this line:

https://github.com/statsbotco/cube.js/blob/d22a809059340e2b7caab7dc8cb122c14e581edd/packages/cubejs-schema-compiler/adapter/BaseQuery.js#L589

There's double escaping.

Ok great, can you please check the update now?

@paveltiunov
Copy link
Member

@dgkmurthy Looks good! Thanks!

@paveltiunov paveltiunov merged commit b8a59da into cube-js:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants