Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newlines shouldn't be required for UDP packets #8

Closed
joeshaw opened this issue Aug 28, 2012 · 3 comments
Closed

newlines shouldn't be required for UDP packets #8

joeshaw opened this issue Aug 28, 2012 · 3 comments

Comments

@joeshaw
Copy link
Contributor

joeshaw commented Aug 28, 2012

UDP packets appear to be discarded if they don't include a newline. In checking 2 different Python client implementations (including the one I use, from py-statsd), neither adds a newline. I doubt it's common.

It might be a good idea to automatically add a newline to the end of received UDP packets when writing to the buffer?

@joeshaw
Copy link
Contributor Author

joeshaw commented Aug 28, 2012

Something like joeshaw/statsite@4dac967 might work. I think it actually breaks the case where the newline is present, but I've run out of time for today. I'll revisit it tomorrow.

@armon
Copy link
Collaborator

armon commented Aug 28, 2012

Good call. Just add a check for an existing new-line, and I will merge it in. Thanks!

@joeshaw
Copy link
Contributor Author

joeshaw commented Aug 29, 2012

code in pull request #9.

@joeshaw joeshaw closed this as completed Aug 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants