Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Improve warnings to avoid generic warnings messages #1510

Merged
merged 2 commits into from Apr 3, 2014

Conversation

bashtage
Copy link
Member

All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

@bashtage
Copy link
Member Author

Has a single file conflict with the test silence PR #1507, but I can rebase the one that goes in 2nd.

@jseabold
Copy link
Member

jseabold commented Apr 3, 2014

Ping us when you rebase on master.

All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

Conflicts:
	statsmodels/tools/sm_exceptions.py
Converted raise Warning to warning.warn

Made certain warnings had been imported in some modules where it was lazily
imported

Simplified warnings in GEE which was neither lazily imported nor imported
at the top of the file
@bashtage
Copy link
Member Author

bashtage commented Apr 3, 2014

@jseabold I have rebased and squashed a small number of warnings that had escaped.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3415486 on bashtage:warning-convert into 2762065 on statsmodels:master.

@josef-pkt
Copy link
Member

looks good to me

jseabold added a commit that referenced this pull request Apr 3, 2014
CLN: Improve warnings to avoid generic warnings messages
@jseabold jseabold merged commit 4164e54 into statsmodels:master Apr 3, 2014
@bashtage bashtage deleted the warning-convert branch April 3, 2014 14:55
@josef-pkt josef-pkt added the PR label Apr 14, 2014
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014
CLN: Improve warnings to avoid generic warnings messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants