New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: exog_names versus param_names #4426
Comments
now wald tests use `cov_names, even more options to store and set names changed in #6012 to support 2-d params model specific My current problem is that I need to figure out where to add the extra params for a new model, and I don't remember or I'm not up-to-date. OrderedModel in #7021 (with 1-dim params) edit negbinP uses GenericLikelihoodModel uses the model attribute for inplace modification and data attribute for setting
MNLogit now sets data.cov_names
|
maybe if exog is None, then xname/exog_name/param_names should be an empty list instead of None.
|
similarly e.g. endog_names and exog_names are properties in
|
There is currently an incomplete refactoring to switch from
exog_names
to the more genericparam_names
.param_names
exog_names
(e.g. count models with extra params)_getnames
usesexog_names
I think, model.exog_names is a reference to data.xnames. When we modify model.exog_names it correctly modifies the names for the pandas wrapper code. (i.e. we need the correct names in
model.data
)Given the last point, it is unlikely that we can make structural changes.
The main refactoring that we might be able to do is to essentially rename exog_names to param_names, and consistently use param_names in all models.
One problem is that we have almost no test coverage for names. e.g. #4340 and some earlier bugs when summary is wrong because the names don't have the right length.
Another issue for summary will be when summary doesn't print the "params", either by dropping some or adding some. But summary methods of individual models can use the
xname
(singular !?) argument in summary supporting code.related
#1970 required attributes
The text was updated successfully, but these errors were encountered: