Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/REF plot_partial_residuals versus plot_partial in GLM/GAM #5473

Open
josef-pkt opened this issue Jan 19, 2019 · 0 comments
Open

ENH/REF plot_partial_residuals versus plot_partial in GLM/GAM #5473

josef-pkt opened this issue Jan 19, 2019 · 0 comments

Comments

@josef-pkt
Copy link
Member

Based on quick skimming, GLMResults.plot_partial_residual is just a CPR (component plus residual) plot for a single column of exog.
However it uses the weights, weighted residuals in the plot. (those might be one of the available residuals)

GLMGamResults.plot_partial plot partial prediction and optional cpr scatter points but only for the linear prediction, using resid_working.
It also adds confidence intervals for the partial linear prediction.

regression plot for OLS also have a CPR plot for a single exog column.

what can we improve, enhance or make more consistent?

(I found plot_partial_residual by tab completion because it was next to the new GAM plot_partial)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant