Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH/TST: inherited post-estimation features for GLMGAM #8519

Open
josef-pkt opened this issue Nov 11, 2022 · 0 comments
Open

ENH/TST: inherited post-estimation features for GLMGAM #8519

josef-pkt opened this issue Nov 11, 2022 · 0 comments
Labels
comp-gam comp-genmod topic-diagnostic topic-post_estim post-estimation results, margins, prediction, inference, diagnostic type-enh type-test
Milestone
0.15

Comments

@josef-pkt
Copy link
Member

from #8505 (comment)

I just saw that GAM inherits from GLM GLMGamResults(GLMResults)
get_prediction calls the super method
extra keywords are in kwargs, so which support and behavior should be inherited from GLM

needs specific unit tests
get_distribution and other post-estimation features will also be inherited

I guess most postestimation should work without problems.
But I never checked any of the new inherited generic features for gam

This will be also another consistency check and check for how generic our generic features are.

penalization should have no effect beyond, params, cov_params and df_xxx (AFAIR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp-gam comp-genmod topic-diagnostic topic-post_estim post-estimation results, margins, prediction, inference, diagnostic type-enh type-test
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
1 participant
@josef-pkt