Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: check and add unit tests for one parameter models #8792

Open
josef-pkt opened this issue Apr 13, 2023 · 3 comments
Open

TST: check and add unit tests for one parameter models #8792

josef-pkt opened this issue Apr 13, 2023 · 3 comments
Assignees
Milestone

Comments

@josef-pkt
Copy link
Member

see #8780 (comment)

AFAIK, we have almost no unit tests if len(params) is 1.

The smallest exog that I usually use has 2 columns, e.g. for 2 independent sample case.

There might be problems and bugs mainly in generic code, as in the approx_fprime case.

@josef-pkt josef-pkt added this to the 0.15 milestone Apr 13, 2023
@jkriv
Copy link

jkriv commented Apr 19, 2023

I would be willing to work on this issue if it is still available!

@josef-pkt
Copy link
Member Author

josef-pkt commented Apr 19, 2023

It's still available.
However, it's not really clear where and how to add those, because we want some kind of parametrized unit tests or reuse existing unit tests.

For example,
I think at test like this https://github.com/josef-pkt/statsmodels/blob/main/statsmodels/discrete/tests/test_predict.py#L348
could include smoke or shape tests for all which in get_prediction(which=xxx)
Where available model specific which would have to be collected, for example in a dictionary, then we could just run the tests for all which in a loop.

aside: hurdle and truncated models are missing in that parametrized list of models.

@josef-pkt
Copy link
Member Author

You don't need to be assigned to an issue to open a pull request. We usually don't assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants