Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD data_files for stats.libqsturng #907

Closed
josef-pkt opened this issue Jun 25, 2013 · 4 comments
Closed

BLD data_files for stats.libqsturng #907

josef-pkt opened this issue Jun 25, 2013 · 4 comments
Labels
build comp-stats

Comments

@josef-pkt
Copy link
Member

originally reported in #831

I did not manage to get the test and data files to install in libqsturng.

I worked around this for the required test data file in PR #905

However copyright and one txt file are in the sdist but are missing in the installed package
@josef-pkt josef-pkt mentioned this issue Jun 25, 2013
Merged
@jseabold
Copy link
Member

Can we close this or is it still something I need to look at?

@josef-pkt
Copy link
Member Author

The workaround (relocating a file) works to get the test suite to pass.

However, it would be good, if you manage to get it to work that the extra files get installed. But we don't need to waste a lot of time on this, if you don't figure out how to get it to work right away.

@josef-pkt
Copy link
Member Author

The missing piece

include_package_data=True,
inside
setup(name = DISTNAME,

see section on Non-Code Files in http://hynek.me/articles/sharing-your-labor-of-love-pypi-quick-and-dirty/

I just tested it in a virtualenv and it installed the missing files in statsmodels.stats.libqsturng

(maybe this was implied by the numpy distutils version)

@josef-pkt
Copy link
Member Author

@jseabold can you just add the one line in the setup.py in master?

My tox testrun with it came back clean.

@josef-pkt josef-pkt mentioned this issue Jul 30, 2013
Merged
jseabold added a commit that referenced this issue Jul 30, 2013
@jseabold
Merge pull request #1001 from statsmodels/fix_setup_data
c5cb393 
BLD: include_package_data for install. Closes #907
@jseabold jseabold mentioned this issue May 12, 2014
Merged
rgommers added a commit to rgommers/statsmodels that referenced this issue May 14, 2014
@rgommers
MAINT: remove unneeded lines from MANIFEST.in; fix typos in setup.py
8a9e62c 
Undoes the workaround for the not-spotted typos from statsmodelsgh-907.

Also remove unused test data file (data itself is in macrodata.py)
rgommers added a commit to rgommers/statsmodels that referenced this issue May 22, 2014
@rgommers
MAINT: remove unneeded lines from MANIFEST.in; fix typos in setup.py
06fb23f 
Undoes the workaround for the not-spotted typos from statsmodelsgh-907.

Also remove unused test data file (data itself is in macrodata.py)
Padarn pushed a commit to Padarn/statsmodels that referenced this issue May 23, 2014
@rgommers @Padarn
MAINT: remove unneeded lines from MANIFEST.in; fix typos in setup.py
86eb129 
Undoes the workaround for the not-spotted typos from statsmodelsgh-907.

Also remove unused test data file (data itself is in macrodata.py)
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@josef-pkt
BUG include_package_data for install closes statsmodels#907
a3d0408
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@jseabold
Merge pull request statsmodels#1001 from statsmodels/fix_setup_data
dfc926f 
BLD: include_package_data for install. Closes statsmodels#907
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@rgommers
MAINT: remove unneeded lines from MANIFEST.in; fix typos in setup.py
63898ec 
Undoes the workaround for the not-spotted typos from statsmodelsgh-907.

Also remove unused test data file (data itself is in macrodata.py)
yarikoptic added a commit to yarikoptic/statsmodels that referenced this issue Oct 23, 2014
@yarikoptic
Merge commit 'v0.4.3-1962-g13bbf88' into debian
199adf0 
* commit 'v0.4.3-1962-g13bbf88': (1762 commits)
  MAINT: Add .mailmap file.
  DOC: Add note about docs to release process.
  GITHUB: Contributing guidlines
  DOC: Fix literal block issue.
  DOC: Don't use substitution notation for abs.
  DOC: Fix literal block.
  DOC: Fix bullet lists.
  DOC: Parameter is NOT a section title.
  DOC: Cannot have arbitrary indents.
  DOC: Remove unknown section title.
  DOC: Fix section header.
  BUG: Workaround for bug in sphinx 1.1.3. See statsmodels#1002.
  DOC: Update maintainer notes with branching instructions.
  BUG include_package_data for install closes statsmodels#907
  STY: Cleanup accidental cruft in comment.
  BUG: Support pandas 0.8.0.
  DOC: acovf -> acf.
  Fixed incorrect arma_acf docstring
  BUG: Handle combo of pandas 0.8.0 and dateutils 1.5.0
  ENH: Print dateutil version.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build comp-stats
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jseabold @josef-pkt