Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_fit_minimize requires update of no_hess list: L-BFGS-B and TNC do not use Hessian information (hess) #9140

Open
pcuestas opened this issue Feb 3, 2024 · 3 comments

Comments

@pcuestas
Copy link

pcuestas commented Feb 3, 2024

L-BFGS-B and TNC do not use Hessian information (hess). Therefore, these methods should be added to

no_hess = ['Nelder-Mead', 'Powell', 'CG', 'BFGS', 'COBYLA', 'SLSQP']

@josef-pkt
Copy link
Member

yes lbfgs are missing but AFAICS we don't have a wrapper for fmin_tnc.

Do you get any problems, exception, ... when running the current code?
I don't understand why this doesn't cause problems when we run the unit tests.

update
no_hess is only used in _fit_minimize and we have few unit tests for it.

@josef-pkt josef-pkt added this to the 0.15 milestone Feb 9, 2024
@josef-pkt
Copy link
Member

we should get at least a smoke test for all methods in _fit_minimize.

@pcuestas
Copy link
Author

I do not have any problem when running the current code, only a warning. Sorry, I should have mentioned this. I just wanted to point this out, as I believe it can be confusing for users to get this warning when there shouldn't be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants