Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wls llf fix #1253

Merged
merged 3 commits into from Dec 19, 2013

Conversation

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Dec 18, 2013

adjusted tests and added tests to @bashtage PR #1251 , supersedes now that PR

open problem: rsquared doesn't match, see #1252 (not for this PR, since I don't know how #1252 is supposed to be "fixed")

llf, aic and bic differ now from Stata, see and closes #1170

@coveralls

This comment has been minimized.

Copy link

commented Dec 18, 2013

Coverage Status

Coverage remained the same when pulling 8e08fa6 on josef-pkt:WLS-llf-fix into cc04669 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2013

I think this is ready to merge, TravisCI is green

josef-pkt added a commit that referenced this pull request Dec 19, 2013

Merge pull request #1253 from josef-pkt/WLS-llf-fix
REF Wls llf fix closes #1170 closes #1251

@josef-pkt josef-pkt merged commit f974da3 into statsmodels:master Dec 19, 2013

1 check passed

default The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:WLS-llf-fix branch Dec 19, 2013

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.