Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El aft rebased #462

Merged
merged 58 commits into from Sep 16, 2012
Merged

El aft rebased #462

merged 58 commits into from Sep 16, 2012

Conversation

josef-pkt
Copy link
Member

rebased version of el_aft PR #427

tests run clean

might need refactoring in future for consistency with a more general survival/AFT subpackage

Also briefly went through can changed int to float per Joesf's suggestion.
I will continue to keep a lookout for these as I'm sure I didn't catch them all.
…ot return an error. It seems to be able to recover from bad nuisance parameters by itself
… empirical likelihood. The EL part will only be used for inference.
j-grana6 and others added 24 commits September 16, 2012 08:34
…has a quadruply nested optimization and is computationally intensive.
…ssion parameter takes a long time because it involves a quadruply nested optimization, which is noted in the documentation.
josef-pkt added a commit that referenced this pull request Sep 16, 2012
El aft rebased

some cleanup will come in a future branch by Justin
@josef-pkt josef-pkt merged commit 4d774a2 into master Sep 16, 2012
@josef-pkt josef-pkt mentioned this pull request Sep 17, 2012
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014
El aft rebased

some cleanup will come in a future branch by Justin
@josef-pkt
Copy link
Member Author

@ShuguangSun A comment in a merged PR/commit will get lost. Please open new issues if you find some problems, so we have an open issue to track problems with existing code.

AFAIK, we never have params as a function/method, It should always be an attribute. Did you find a problem with an example for this?

@ShuguangSun
Copy link

koul_and_mc.py is an example. It throws and an error for fit().params. In aft_el.py, params is a method, and not a attribute.

I will open an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants