New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc07 cleanup multipletesting and proportions #784
Conversation
for m in _alias_list: | ||
multitest_alias[m[0]] = m[0] | ||
for a in m[1:]: | ||
multitest_alias[m[0]] = a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this goes the wrong way, should be multitest_alias[a] = m[0]
almost done here proportion has essentially full coverage (but maybe not all options or use cases) left to do: |
The last commit cd69578 added some new stuff that are not yet unit tested. Most of it is copy paste to finish up some loose ends and add generic versions, for example add the methods for ztest and ztost to weightstats. I wrote those changes some time ago, and I'm not sure what the status is. |
Pretty much done here. The docstrings should get another review. I did some interface consistency changes. Some options still vary across functions and methods, but I leave that for the next round, which will also bring in tests for correlation, which are again based on normal distribution (ztest) after transforming the test statistic. (Still bugging: it still uses |
missing : add new functions and methods to api and sphinx docs |
I'm going to rebase, force push and then merge. |
add 'fdr_twostage' option to multipletests, some doc improvement
tests pass but needs proof reading
…rn after 1st stage
…for positional arguments
travisCI python 2 fails again with python-dateutil, python 3.2 passes merging |
Misc07 cleanup : multipletesting, proportions, weightstats
Misc07 cleanup : multipletesting, proportions, weightstats
first part: some cleanup of multipletesting,
see also http://jpktd.blogspot.ca/2013/04/multiple-testing-p-value-corrections-in.html
closes #763
closes #764
closes #766
Note: includes several backwards incompatible renames in weightstats
second part: statistical test for proportions and normal based tests
some functions still miss unit tests :
currently all written as individual functions :
some functions are still missing (ztest_prop, with more options than generic ztest), mostly done, I think
adding ztest and ztost to weightstats is incomplete (not attached as methods) DONE
ddof again: