ENH: Allow pandas-in/pandas-out in tsa.filters #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can change this to use a decorator, but I assumed this was preferable. |
| if hasattr(X, "columns"): | ||
| return lambda x : X.__class__(x, index=index, columns=X.columns) | ||
| else: | ||
| return lambda x : X.__class__(x, index=index, name=X.name) |
There was a problem hiding this comment.
explicit
else:
return None
would be clearer to follow.
Looks like a useful helper function
AFAICS output has same shape as the input except for trimming
|
More explicit naming. |
|
Re: generality, I could see it evolve into a useful decorator (less work to use), but I'd need to look at some more use cases first. Just noticed this in the tutorials and it was low hanging. |
jseabold
added a commit
that referenced
this pull request
Apr 26, 2013
ENH: Allow pandas-in/pandas-out in tsa.filters
PierreBdR
pushed a commit
to PierreBdR/statsmodels
that referenced
this pull request
Sep 2, 2014
ENH: Allow pandas-in/pandas-out in tsa.filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #793.