Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Rework scroll method #571

Open
anastasiyaig opened this issue Mar 6, 2024 · 1 comment
Open

Rework scroll method #571

anastasiyaig opened this issue Mar 6, 2024 · 1 comment
Labels
Squish Tasks related to Squish framework but not necessarily related to tests implementation
Milestone

Comments

@anastasiyaig
Copy link
Collaborator

anastasiyaig commented Mar 6, 2024

Scroll method can lead to infinite loop

https://ci.status.im/job/status-desktop/job/e2e/job/prs/1983/allure/#testresult/23f01f6862da577

Screenshot 2024-03-06 at 12 21 02 Screenshot 2024-03-06 at 12 22 08

We need to rework this somehow so this is not happening anymore

We have 2 scroll methods and they both work weird

self._scroll.vertical_down_to
self._scroll.vertical_scroll_to
@anastasiyaig anastasiyaig added the Squish Tasks related to Squish framework but not necessarily related to tests implementation label Mar 6, 2024
@anastasiyaig anastasiyaig added this to the 2.28.0 Beta milestone Mar 6, 2024
@anastasiyaig anastasiyaig modified the milestones: 2.28.0 Beta, 2.30.0 Beta Mar 29, 2024
@anastasiyaig anastasiyaig modified the milestones: 2.30.0 Beta, 2.29.0 Beta May 3, 2024
@anastasiyaig
Copy link
Collaborator Author

anastasiyaig commented May 28, 2024

talked to @caybro and there is a suggestion to use this within StatusScrollView:

    function scrollHome() {
        flickable.contentY = 0
    }

    function scrollEnd() {
        flickable.contentY = flickable.contentHeight - flickable.height
    }

    function scrollPageUp() {
        root.ScrollBar.vertical.decrease()
    }

    function scrollPageDown() {
        root.ScrollBar.vertical.increase()
    }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Squish Tasks related to Squish framework but not necessarily related to tests implementation
Projects
None yet
Development

No branches or pull requests

1 participant